net/http2: pool transport gzip readers #239

AlexanderYastrebov · 2025-10-08T16:35:16Z

This is a copy of the CL 510255 with the difference that
it preserves use of fs.ErrClosed when reading after close.

goos: darwin
goarch: arm64
pkg: golang.org/x/net/http2
cpu: Apple M4
│ HEAD~1 │ HEAD │
│ sec/op │ sec/op vs base │
ClientGzip-10 752.8µ ± 1% 750.7µ ± 2% ~ (p=0.393 n=10)

          │    HEAD~1    │                 HEAD                 │
          │     B/op     │     B/op      vs base                │

ClientGzip-10 75.49Ki ± 0% 33.98Ki ± 3% -54.99% (p=0.000 n=10)

          │   HEAD~1   │               HEAD                │
          │ allocs/op  │ allocs/op   vs base               │

ClientGzip-10 705.0 ± 0% 698.5 ± 0% -0.92% (p=0.000 n=10)

Updates golang/go#61353

gopherbot · 2025-10-08T16:43:12Z

This PR (HEAD: 5e48e81) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/net/+/710235.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-10-08T16:58:50Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/710235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-08T16:58:51Z

Message from Alexander Yastrebov:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/710235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-08T20:41:04Z

Message from Sean Liao:

Patch Set 2: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/710235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-08T20:48:56Z

Message from Go LUCI:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-10-08T20:32:55Z","revision":"8e3e4d8fcffc1ff884c8c9290d9b1865375baa7b"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/710235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-08T20:48:57Z

Message from Sean Liao:

Patch Set 2: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/710235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-08T20:48:57Z

Message from Go LUCI:

Patch Set 2:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/710235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-08T20:48:58Z

Message from Go LUCI:

Patch Set 2: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/710235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-09T23:15:49Z

Message from Sean Liao:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/710235.
After addressing review feedback, remember to publish your drafts!

For golang/go#61353

This is a copy of the CL 510255 with the difference that it preserves use of fs.ErrClosed when reading after close. goos: darwin goarch: arm64 pkg: golang.org/x/net/http2 cpu: Apple M4 │ HEAD~1 │ HEAD │ │ sec/op │ sec/op vs base │ ClientGzip-10 752.8µ ± 1% 750.7µ ± 2% ~ (p=0.393 n=10) │ HEAD~1 │ HEAD │ │ B/op │ B/op vs base │ ClientGzip-10 75.49Ki ± 0% 33.98Ki ± 3% -54.99% (p=0.000 n=10) │ HEAD~1 │ HEAD │ │ allocs/op │ allocs/op vs base │ ClientGzip-10 705.0 ± 0% 698.5 ± 0% -0.92% (p=0.000 n=10) Updates golang/go#61353

gopherbot · 2025-10-10T12:47:32Z

This PR (HEAD: 4d04dc9) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/net/+/710235.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-10-10T12:55:25Z

Message from Alexander Yastrebov:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/710235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-12T17:35:35Z

Message from Sean Liao:

Patch Set 3: Code-Review+2 Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/710235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-12T17:42:45Z

Message from Go LUCI:

Patch Set 3:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-10-12T17:26:03Z","revision":"d9d2957a636f1d0545124b73575609a8f86bdbd4"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/710235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-12T17:42:45Z

Message from Sean Liao:

Patch Set 3: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/710235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-12T17:42:46Z

Message from Go LUCI:

Patch Set 3:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/710235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-12T17:42:47Z

Message from Go LUCI:

Patch Set 3: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/710235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-13T16:49:37Z

Message from Michael Pratt:

Patch Set 3: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/710235.
After addressing review feedback, remember to publish your drafts!

This is a copy of the CL 510255 with the difference that it preserves use of fs.ErrClosed when reading after close. goos: darwin goarch: arm64 pkg: golang.org/x/net/http2 cpu: Apple M4 │ HEAD~1 │ HEAD │ │ sec/op │ sec/op vs base │ ClientGzip-10 752.8µ ± 1% 750.7µ ± 2% ~ (p=0.393 n=10) │ HEAD~1 │ HEAD │ │ B/op │ B/op vs base │ ClientGzip-10 75.49Ki ± 0% 33.98Ki ± 3% -54.99% (p=0.000 n=10) │ HEAD~1 │ HEAD │ │ allocs/op │ allocs/op vs base │ ClientGzip-10 705.0 ± 0% 698.5 ± 0% -0.92% (p=0.000 n=10) Updates golang/go#61353 Change-Id: I0fdc0c0a5947d27dcc615e5bcf4d4620c2c95d9e GitHub-Last-Rev: 4d04dc9 GitHub-Pull-Request: #239 Reviewed-on: https://go-review.googlesource.com/c/net/+/710235 Reviewed-by: Sean Liao <[email protected]> Reviewed-by: Michael Pratt <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Damien Neil <[email protected]> Auto-Submit: Damien Neil <[email protected]>

gopherbot · 2025-10-16T00:16:10Z

This PR is being closed because golang.org/cl/710235 has been merged.

kmk142789 approved these changes Oct 9, 2025

View reviewed changes

AlexanderYastrebov added 2 commits October 10, 2025 14:38

http2: add transport gzip response benchmark

32b70f4

For golang/go#61353

AlexanderYastrebov force-pushed the go61353 branch from 5e48e81 to 4d04dc9 Compare October 10, 2025 12:42

gopherbot closed this Oct 16, 2025

net/http2: pool transport gzip readers #239

net/http2: pool transport gzip readers #239

Uh oh!

Conversation

AlexanderYastrebov commented Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gopherbot commented Oct 8, 2025

Uh oh!

gopherbot commented Oct 8, 2025

Uh oh!

gopherbot commented Oct 8, 2025

Uh oh!

gopherbot commented Oct 8, 2025

Uh oh!

gopherbot commented Oct 8, 2025

Uh oh!

gopherbot commented Oct 8, 2025

Uh oh!

gopherbot commented Oct 8, 2025

Uh oh!

gopherbot commented Oct 8, 2025

Uh oh!

gopherbot commented Oct 9, 2025

Uh oh!

gopherbot commented Oct 10, 2025

Uh oh!

gopherbot commented Oct 10, 2025

Uh oh!

gopherbot commented Oct 12, 2025

Uh oh!

gopherbot commented Oct 12, 2025

Uh oh!

gopherbot commented Oct 12, 2025

Uh oh!

gopherbot commented Oct 12, 2025

Uh oh!

gopherbot commented Oct 12, 2025

Uh oh!

gopherbot commented Oct 13, 2025

Uh oh!

gopherbot commented Oct 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

AlexanderYastrebov commented Oct 8, 2025 •

edited

Loading